Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have enhanced your plugin to allow the user to configure the JDK to use when running Fitnesse. The plugin provides a dropdown of Jenkins installed JDKs, unless only one is installed, in which case the default is used. This will override the java executable which is used to invoke Fitnesse.
We have found this useful in the case that we must develop and compile against Java 5 while we want to acceptance test with the latest versions of Fitnesse which require Java 6.
Please note that at the time I forked and implemented this, there were 3 unit tests failing and several tests commented out. I have added a few unit tests around the new functionality and have not introduced any new failures.